Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Visual C# method calls using too much memory?

I'm writing a game using the XNA 4.0 framework. I've written a set of methods that translates the 2D mouse coordinates to a line in the 3d world, then checks to see if that line intersects a plane, and if the intersection point is within the bounds of a face in that plane.

The math works, but for some reason when I do these calculations over 500 times a frame it brings the program to a halt. I can watch the memory usage climb from starting at 15 MB to about 130 MB before garbage collection decides to clean things up. I know specifically it is in this code because when I comment it out, everything else runs smoothly.

I'll paste my code below, any insight would be helpful and thank you!

The Loop:

            GraphicObject me = new GraphicObject();
            Intersection intersect;
            double? dist = null;

            foreach (GraphicObject obj in GraphicObjects)
            {
                intersect = obj.intersectMe(line);
                if (intersect.Distance != null)
                {
                    if (intersect.Distance < dist || dist == null)
                    {
                        dist = intersect.Distance;
                        me = obj;
                    }
                    else
                    {
                        obj.Highlight(false);
                    }
                }
                else
                {
                    obj.Highlight(false);
                }
            }

            if (dist != null)
            {
                me.Highlight(true);
            }

intersectMe:

    public override Intersection intersectMe(Ray _line)
    {
        GraphicHelper.Intersects(_line, rect.Vertices[0].Normal, rect.Vertices[0].Position, intersect);

        if (intersect.Distance != null)
        {
            if (!rect.PointOnMe(intersect.X - position.X, intersect.Y - position.Y, intersect.Z - position.Z))
            {
                intersect.Distance = null;
            }
        }

        return intersect;
    }

GraphicsHelper.Intersects:

    // _l = line, _n = normal to plane, _p = point on the plane
    public static void Intersects(Ray _l, Vector3 _n, Vector3 _p, Intersection _i)
    {
        _i.Distance = null;

        float num = (_n.X * (_p.X - _l.Position.X) + _n.Y * (_p.Y - _l.Position.Y) + _n.Z * (_p.Z - _l.Position.Z));

        float denom = (_n.X * _l.Direction.X + _n.Y * _l.Direction.Y + _n.Z * _l.Direction.Z);

        if (denom != 0 && num != 0)
        {
            float t = num / denom;

            if (t > 0)
            {
                _i.X = _l.Position.X + _l.Direction.X * t;
                _i.Y = _l.Position.Y + _l.Direction.Y * t;
                _i.Z = _l.Position.Z + _l.Direction.Z * t;

                _i.Distance = _i.X * _i.X + _i.Y * _i.Y + _i.Z * _i.Z;
            }
        }
    }

PointOnMe:

    public bool PointOnMe(float _x, float _y, float _z)
    {
        float ex = _x - Vertices[3].Position.X;
        float ey = _y - Vertices[3].Position.Y;
        float ez = _z - Vertices[3].Position.Z;

        float ae = a.X * ex + a.Y * ey + a.Z * ez;
        float be = b.X * ex + b.Y * ey + b.Z * ez;

        ex = _x - Vertices[1].Position.X;
        ey = _y - Vertices[1].Position.Y;
        ez = _z - Vertices[1].Position.Z;

        float ce = c.X * ex + c.Y * ex + c.Z * ez;
        float de = d.X * ex + d.Y * ey + d.Z * ez;

        if (ae > 0 && be > 0 && ce > 0 && de > 0)
        {
            return true;
        }
        else
        {
            return false;
        }
    }
like image 365
Talmien Avatar asked Dec 05 '25 07:12

Talmien


1 Answers

Thank you all for taking some time to look at this for me. The error was actually in how I handle obj.Highlight(), TaW's kick in the butt to get a profiler setup helped me to figure that out.

    public override void Highlight(bool toggle)
    {
        if(toggle)
        {
            rect.Texture = new Texture2D(GraphicsManager.Graphics.GraphicsDevice, 1, 1);
            rect.Texture.SetData<Color>(new Color[] { Color.Yellow });
        }
        else
        {
            rect.Texture = new Texture2D(GraphicsManager.Graphics.GraphicsDevice, 1, 1);
            rect.Texture.SetData<Color>(new Color[] { squareColor });
        }
    }

Every frame all the obj's were having new textures generated. A terrible way to do things.

like image 198
Talmien Avatar answered Dec 10 '25 22:12

Talmien