Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

why does Guava's Sets::hashCodeImpl have a weird loop update with double complement?

Guava computes the hash code of a set like this:

static int hashCodeImpl(Set<?> s) {
    int hashCode = 0;

    for(Iterator var2 = s.iterator(); var2.hasNext(); hashCode = ~(~hashCode)) {
        Object o = var2.next();
        hashCode += o != null ? o.hashCode() : 0;
    }

    return hashCode;
}

this is efficient and elegant - we use a commutative operation (addition) to "mix in" the hash codes of the objects, so that we get the same value regardless of order we iterate over the elements.

What I'm not sure about is the update condition in the for loop: hashCode = ~(~hashCode) seems to have no effect (IntelliJ's code inspector suggests to simplify the expression and then remove the self-assignment).

What's going on?

like image 674
Just Me Avatar asked Nov 21 '25 18:11

Just Me


1 Answers

Although still a tad cryptic, the latest source code explains it (introduced by 86aa9f0):

hashCode = ~~hashCode;
// Needed to deal with unusual integer overflow in GWT.
like image 77
sp00m Avatar answered Nov 24 '25 08:11

sp00m



Donate For Us

If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!