Use the same `before_action` filter in multiple controllers

Question

In a Rails app, I have a before_action filter that sends a webhook message. Since I have a few controllers that I want the before_action to act on, is there a good way to make it a module and prepend it?

My current logic is:

# first_controller.rb:
before_action :do_something
def do_something
 #same logic
end

# second_controller.rb:
before_action :do_something
def do_something
 #same logic
end

# third_controller.rb:
before_action :do_something
def do_something
 #same logic
end

Answer 1

If your controllers inherit from ApplicationController, You can do the following:

class ApplicationController < ActionController::Base
  def do_something
   #same logic
  end
end

class FirstController < ApplicationController
  before_action :do_something
end
class SecondController < ApplicationController
  before_action :do_something
end
class ThirdController < ApplicationController
  before_action :do_something
end

Or you can make your own parent controller, eg. DoSomethingController

class DoSomethingController < ApplicationController
  before_action do_something

  def do_something
   #same logic
  end
end

class FirstController < DoSomethingController
end
class SecondController < DoSomethingController
end
class ThirdController < DoSomethingController
end

Or you can use @code_aks's answer https://stackoverflow.com/a/59846330/8554172 to make a module and include it.

Answer 2

Yes, it is good to use DRY here. If your controllers do have same parent class you can place that method in there. If not it is good practice to move this method to the module and include it with reusing.