Which conditional statement is correct?

Question

Of the following, which conditional statement is best practice:

if ($_GET['type'] == 'user' || $_GET['type'] == 'salesmen')

or

if ($_GET['type'] == ('user' || 'salesmen'))

Thanks for your help.

Answer 1

Always use the first one:

if ($_GET['type'] == 'user' || $_GET['type'] == 'salesmen')

The second one is a valid PHP ststement but it will produce unexpected results ( Not the output you are expecting ).

Answer 2

Have you tried it? One simple try would point you that the second part will not work as you expected.

However, I would suggest in_array()

if (in_array($_GET['type'], array('user', 'salesmen'))) {
   //
}

or

$type = array('user', 'salesmen');
if (in_array($_GET['type'], $type)) {
    //
}