In Angular would it be ok/proper to have the constructor above class variables?

Question

IE: instead of this:

export class MyComponent implements OnInit {
  users: User[];
  error_message: string;
  constructor(public authService: AuthService, public router: Router) { }

This (Looks cleaner and more proper to me)

export class MyComponent implements OnInit {
  constructor(public authService: AuthService, public router: Router) { }
  users: User[];
  error_message: string;

I couldn't find any documentation on this in the Angular style guide: https://angular.io/guide/lifecycle-hooks

Answer 1

Is it okay? Sure it is okay. Is it proper - that is debatable. It certainly is not conventional.

What happens when you start needing to use your member variables in your constructor?

In this case: If you continue to declare your variables below your constructor, sure it will work, but it certainly isn't pleasant for readability. Alternatively in this case you could declare those member variables above your constructor, but then you will have inconsistencies in you files. (i.e. some files with member variables defined before the constructor and some defined after.)

I'd recommend sticking to the convention of defining all your member variables at the beginning of the class prior to the constructor, but hey that is just my two cents! :)