how can i know when i reach end of a datareader?

Question

cmd.CommandText = "select name from Tbl_Shahr_No";
SqlDataReader reader = null;
reader = cmd.ExecuteReader();
reader.Read();

while(reader.HasRows)
{
    ddl.Items.add(reader["name"].tostring());
    reader.read()
}

i wrote this code but problem is that while statement is true all times! how can i read all of reader information with a while or repeater ring?

Answer 1

The simplest idea is to simply let Read() be the loop condition.

while (reader.Read())
{
     // grab data
}

Answer 2

Use the .Read() method in your while.

It advances the SqlDataReader to the next record.

Returns true if there are more rows; otherwise false.

while(reader.Read())
{
   ddl.Items.add(reader["name"].ToString());
}

Alternatively, data-bind your dropdownlist to your SqlDataReader, and don't bother iterating it manually.

ddl.DataSource = reader;
ddl.DataTextField = "name";
ddl.DataValueField = "name";
ddl.DataBind();