c - string manipulation to struct member

Question

Based on my previous post, I came up with the following code. I'm sure there is a better way of doing it. I'm wondering, what would that be?

It does split the string if greater than max chars OR if @ is found. Any ideas would be appreciated!

#define _GNU_SOURCE
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

struct my_struct { 
  char *str;
};

int main () {
  struct my_struct *struc;

  int max = 5;
  char *tmp = "Hello World@Foo Bar In here@Bar Foo dot com@here@there";

  struc = malloc (20 * sizeof (struct my_struct));

  int strIdx = 0, offSet = 0;
  char *p = tmp;
  char *tmpChar = malloc (strlen (tmp) + 1), *save;
  save = tmpChar;

  while (*p != '\0') {
    if (offSet < max) {             
      offSet++;
      if (*p == '@') {
        if (offSet != 1) {
          *tmpChar = '\0';
          struc[strIdx++].str = strndup (save, max);
          save = tmpChar;
        }
        offSet = 0;
      } else
        *tmpChar++ = *p; 
    } else {                    // max
      offSet = 0;
      *tmpChar = '\0';
      struc[strIdx++].str = strndup (save, max);
      save = tmpChar;
      continue;
    }   
    p++;
  }
  struc[strIdx++].str = strndup (save, max);    // last 'save'

  for (strIdx = 0; strIdx < 11; strIdx++)
    printf ("%s\n", struc[strIdx].str);

  for (strIdx = 0; strIdx < 11; strIdx++)
    free (struc[strIdx].str);
  free (struc);
  return 0;
}

Output at 5 chars max:

Hello
 Worl
d
Foo B
ar In
 here
Bar F
oo do
t com
here
there

Answer 1

Alright, I'll take a crack at it. First, let me say that my formatting changes were for me. If you don't like lonely {s, that's fine.

#define _GNU_SOURCE
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define MAX 5

struct string_bin
{ 
    char *str;
};


int main ()
{
    struct string_bin *strings;

    char *tmp = "Hello World@Foo Bar In here@Bar Foo dot com@here@there";

    char *p = tmp;
    strings = malloc (20 * sizeof (struct string_bin));
    memset(strings, 0, 20 * sizeof (struct string_bin));

    int strIdx = 0, offset = 0;
    char *cursor, *save;

    strings[strIdx].str = malloc(MAX+1);
    save = strings[strIdx].str;
    while (*p != '\0')
    {
        if (offset < MAX && *p != '@')
        {
            *(save++) = *(p++);
            offset++;
            continue;
        }
        else if (*p == '@')
            *p++;
        offset = 0;
        *save = '\0';
        strings[++strIdx].str = malloc(MAX+1);
        save = strings[strIdx].str;
    }
    *save = '\0';

    for (strIdx = 0; strings[strIdx].str != NULL; strIdx++)
    {
        printf ("%s\n", strings[strIdx].str);
        free (strings[strIdx].str);
    }

    free (strings);

    return 0;
}

The big change is that I got rid of your strdup calls. Instead, I stuffed the string directly into its destination buffer. I also made more calls to malloc for individual string buffers. That lets you not know the length of the input string ahead of time at the cost of a few extra allocations.