Angular6 Material Dialog prevent from closing when pressing enter

Question

I have a login dialog and want to prevent it from closing automatically when enter is pressed.

To be more specific, when the user put the credential and pressed enter and the response for credential came back as error, I want the dialog to stay (so I can show them some error message and let the user try once again).

So this is what I did:

export class LoginComponent {
    constructor(public dialogRef: MatDialogRef<LoginComponent>) { }

    onSubmit(): void {  
        this.authService.login(...)
            .subscribe(res => { 
                ... 
             },
            error => {
                this.dialogRef.disableClose = true;
            }
    }
}

this.dialogRef.disableClose = true; still closes the dialog even though the response came back as error.

How should I do this?

Edit

login.component.ts

<mat-toolbar>
    <span>Login</span>
</mat-toolbar>
<mat-card class="my-card">
    <div *ngIf="error" style="color: red;">{{error}}</div><br />
    <form (ngSubmit)="onSubmit()" [formGroup]="loginForm">     
        <mat-card-content>       
            <mat-form-field appearance="outline" class="full-width">
                <mat-label>Email</mat-label>
                <input matInput placeholder="Email" 
                   formControlName="email" 
                   [formControl]="emailFormControl" 
                   [errorStateMatcher]="matcher" />
                <mat-error *ngIf="emailFormControl.hasError('email') && !emailFormControl.hasError('required')">
                    Enter valid email address
                </mat-error>   
                <mat-error *ngIf="emailFormControl.hasError('required')">
                    Required field
                </mat-error>
            </mat-form-field>
            <mat-form-field appearance="outline" class="full-width">
                <mat-label>Password</mat-label>
                <input matInput type="password" 
                   placeholder="Password" 
                   formControlName="password" 
                   [formControl]="passwordFormControl" 
                   [errorStateMatcher]="matcher" />
                <mat-error *ngIf="passwordFormControl.hasError('required')">
                    Required field
                </mat-error>
            </mat-form-field>                
        </mat-card-content>
        <mat-card-actions>
            <button mat-raised-button (click)="onNoClick()" color="primary">Close</button>
            <button mat-raised-button 
                [disabled]="!(loginForm.controls.email.valid && loginForm.controls.password.valid)" 
                color="accent">
                Login
            </button>
        </mat-card-actions>
    </form>
</mat-card>

login.component.ts

onSubmit(): void {       
    if (this.loginForm.invalid) {
        return;
    }             
    this.authService.login(this.loginForm.controls.email.value, this.loginForm.controls.password.value)
        .subscribe(res => {               
            if (res) {
                alert("logged in");              
            }   
        },
        error => {                  
            this.error = 'Error! Plese try again.'; 
        }
    );       
}

Answer 1

I believe it's because your "CLOSE" button, is not set to type="button", and I THINK that's the first element that has focus, so when pressing enter, you are entering that button, which by default, will submit the form. Add type="button" and that should solve it.

Also for the record, the latest version of angular material has md-button automatically add type="button" by default (unless you specify type="submit") to avoid this type of situation

Use this

 <mat-card-actions>
        <button  mat-raised-button type="button" (click)="onNoClick()" color="primary">Close</button>
        <button  mat-raised-button type="submit" 
            [disabled]="!(loginForm.controls.email.valid && loginForm.controls.password.valid)" 
            color="accent">
            Login
        </button>
    </mat-card-actions>