Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How to Keep RecyclerView's Buttons Clicked Respectfully - Android

I have a RecyclerView that is populated with CardViews. On each of the CardViews there is a button, which up votes the post.

Here is what the button looks when it is not pressed,

up vote - not pressed

Here is what the button looks when it is pressed,

up vote - pressed

My code works for achieving this but I have a problem since it is a RecyclerView. When I scroll down the posts the RecyclerView recycles the previous posts that have been up voted. So a post will show that it was up voted even though a user never up voted it.

How can I keep the buttons pressed respectfully for each CardView?

This is my Adapter

public class DiscoverRecyclerAdapter
        extends RecyclerView.Adapter<DiscoverRecyclerAdapter.ViewHolder> {

    private String[] mDataset;

    Typeface customFont;

    // Provide a reference to the views for each data item
    // Complex data items may need more than one view per item, and
    // you provide access to all the views for a data item in a view holder
    public static class ViewHolder extends RecyclerView.ViewHolder {
        public TextView mTitle;
        public TextView mVoterCounter;
        public ImageButton mVoterButton;
        public ViewHolder(android.support.v7.widget.CardView v) {
            super(v);
            mTitle = (TextView) v.findViewById(R.id.title);
            mVoterCounter = (TextView) v.findViewById(R.id.voter_counter);

            //Initialize voter button
            mVoterButton = (ImageButton)v.findViewById(R.id.voter);

            mVoterButton.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {
                    mVoterButton.setImageResource(R.drawable.ic_voter_pressed);
                }
            });
        }
    }

    // Provide a suitable constructor (depends on the kind of dataset)
    public DiscoverRecyclerAdapter(String[] myDataset, Typeface passedFont) {
        mDataset = myDataset;
        customFont = passedFont;
    }

    // Create new views (invoked by the layout manager)
    @Override
    public DiscoverRecyclerAdapter.ViewHolder onCreateViewHolder(ViewGroup parent,
                                                   int viewType) {
        // create a new view
        View v = LayoutInflater.from(parent.getContext())
                .inflate(R.layout.item_discover, parent, false);
        // set the view's size, margins, paddings and layout parameters
        return new ViewHolder((android.support.v7.widget.CardView)v);
    }

    // Replace the contents of a view (invoked by the layout manager)
    @Override
    public void onBindViewHolder(ViewHolder holder, int position) {
        holder.mTitle.setText(mDataset[position]);
        holder.mTitle.setTypeface(customFont);
        holder.mVoterCounter.setTypeface(customFont);
    }

    // Return the size of your dataset (invoked by the layout manager)
    @Override
    public int getItemCount() {
        return mDataset.length;
    }
}
like image 516
Gary Holiday Avatar asked Jan 20 '26 16:01

Gary Holiday


1 Answers

along with mDataset you will also need a boolean array say mIsSelected now size of this will be equal to size of array mDataSet or create class if you want.

Then in onBindViewHolder do as

 if(mIsSelected[position]
  mVoterButton.setImageResource(R.drawable.ic_voter_pressed);
else
 mVoterButton.setImageResource(R.drawable.ic_voter_unpressed);

and move button onclick inside onBindViewHolder as below

 holder.mVoterButton.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
              mVoterButton.setImageResource(R.drawable.ic_voter_pressed);
              mIsSelected[position] = true;
            }
        });
like image 99
amodkanthe Avatar answered Jan 23 '26 08:01

amodkanthe