Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Hibernate change some line of code get APPARENT DEADLOCKS

I using Oracle database and my java application use Hibernate 3.3.2 to interact with it.

I alway use code like this to connect to DB

public void method() {
        Session session = HibernateSessionFactory.getSessionFactory().openSession();
        String sqlSelect = "SELECT sql ...";        
        Transaction tran = session.beginTransaction();
        SQLQuery sqlSelectQuery = session.createSQLQuery(sqlSelect).;
        sqlSelectQuery.setString("PARAM", param);
        boolean ok = true;
        try {
            List list = sqlSelectQuery.list();
            if (list.size() > 0) {
                String updateSql = "UPDATE ....";
                SQLQuery updateQuery = session.createSQLQuery(updateSql);
                updateQuery.setString("PARAM", param);                
                updateQuery.executeUpdate();
            }
        } catch (Exception ex) {
            ok = false;
            tran.rollback();  
            ex.printStackTrace()            
        }
        try {
            if (ok) {
                tran.commit();
            }
            session.close();
        } catch (Exception ex) {  
            ex.printStackTrace()    
        }        
    }

It worker perfect and never getting error.

But when i change to: (only add try, catch, and finally to close hibernate session completely)

public void method() {
        Session session = null
        try{
            session = HibernateSessionFactory.getSessionFactory().openSession();        
            String sqlSelect = "SELECT sql ...";        
            Transaction tran = session.beginTransaction();
            SQLQuery sqlSelectQuery = session.createSQLQuery(sqlSelect).;
            sqlSelectQuery.setString("PARAM", param);
            boolean ok = true;
            try {
                List list = sqlSelectQuery.list();
                if (list.size() > 0) {
                    String updateSql = "UPDATE ....";
                    SQLQuery updateQuery = session.createSQLQuery(updateSql);
                    updateQuery.setString("PARAM", param);                
                    updateQuery.executeUpdate();
                }
            } catch (Exception ex) {
                ok = false;
                tran.rollback();  
                ex.printStackTrace()            
            }
            try {
                if (ok) {
                    tran.commit();
                }
                session.close();
            } catch (Exception ex) {  
                ex.printStackTrace()    
            }    
        }catch (HibernateException hibernateException) {
            hibernateException.printStackTrace();

        } finally {
            if ((session != null) && (session.isOpen())) {
                session.close();
            }

        }
    }

Then i get a lot of APPARENT DEADLOCKS.

[Timer-2] 24/06/2014 21:33:11  WARN ThreadPoolAsynchronousRunner: Task com.mchange.v2.resourcepool.BasicResourcePool$1DestroyResourceTask@1e093f32 (in deadlocked PoolThread) failed to complete in maximum time 60000ms. Trying interrupt().
[Timer-2] 24/06/2014 21:33:11  WARN ThreadPoolAsynchronousRunner: Task com.mchange.v2.resourcepool.BasicResourcePool$AsyncTestIdleResourceTask@7113fb05 (in deadlocked PoolThread) failed to complete in maximum time 60000ms. Trying interrupt().
[Timer-2] 24/06/2014 21:33:11  WARN ThreadPoolAsynchronousRunner: Task com.mchange.v2.resourcepool.BasicResourcePool$AsyncTestIdleResourceTask@56c53f42 (in deadlocked PoolThread) failed to complete in maximum time 60000ms. Trying interrupt().
[Timer-2] 24/06/2014 21:33:11  WARN ThreadPoolAsynchronousRunner: com.mchange.v2.async.ThreadPoolAsynchronousRunner$DeadlockDetector@47ecfc46 -- APPARENT DEADLOCK!!! Creating emergency threads for unassigned pending tasks!
[Timer-2] 24/06/2014 21:33:11  WARN ThreadPoolAsynchronousRunner: com.mchange.v2.async.ThreadPoolAsynchronousRunner$DeadlockDetector@47ecfc46 -- APPARENT DEADLOCK!!! Complete Status: 
                Managed Threads: 3
                Active Threads: 3
                Active Tasks: 
                                com.mchange.v2.resourcepool.BasicResourcePool$AsyncTestIdleResourceTask@72937d83 (com.mchange.v2.async.ThreadPoolAsynchronousRunner$PoolThread-#2)
                                com.mchange.v2.resourcepool.BasicResourcePool$AsyncTestIdleResourceTask@31155e39 (com.mchange.v2.async.ThreadPoolAsynchronousRunner$PoolThread-#1)
                                com.mchange.v2.resourcepool.BasicResourcePool$AsyncTestIdleResourceTask@71dd095b (com.mchange.v2.async.ThreadPoolAsynchronousRunner$PoolThread-#0)
                Pending Tasks: 
                                com.mchange.v2.resourcepool.BasicResourcePool$AsyncTestIdleResourceTask@66916fc3
                                com.mchange.v2.resourcepool.BasicResourcePool$AsyncTestIdleResourceTask@56409fd0
                                com.mchange.v2.resourcepool.BasicResourcePool$1DestroyResourceTask@2cbc3ced
                                com.mchange.v2.resourcepool.BasicResourcePool$1DestroyResourceTask@7a44028c
                                com.mchange.v2.resourcepool.BasicResourcePool$1DestroyResourceTask@703740a
                                com.mchange.v2.resourcepool.BasicResourcePool$1DestroyResourceTask@73b7401e
                                com.mchange.v2.resourcepool.BasicResourcePool$1DestroyResourceTask@3d2acec
                                com.mchange.v2.resourcepool.BasicResourcePool$AcquireTask@7c56bbe9
                                com.mchange.v2.resourcepool.BasicResourcePool$AcquireTask@224afdc5
                                com.mchange.v2.resourcepool.BasicResourcePool$AcquireTask@695aa219
                                com.mchange.v2.resourcepool.BasicResourcePool$AcquireTask@3d484d58
                                com.mchange.v2.resourcepool.BasicResourcePool$AcquireTask@55cdebd6
Pool thread stack traces:
                Thread[com.mchange.v2.async.ThreadPoolAsynchronousRunner$PoolThread-#2,5,main]
                                java.net.SocketInputStream.socketRead0(Native Method)
                                java.net.SocketInputStream.read(SocketInputStream.java:129)
                                oracle.net.ns.Packet.receive(Unknown Source)
                                oracle.net.ns.DataPacket.receive(Unknown Source)
                                oracle.net.ns.NetInputStream.getNextPacket(Unknown Source)
                                oracle.net.ns.NetInputStream.read(Unknown Source)
                                oracle.net.ns.NetInputStream.read(Unknown Source)
                                oracle.net.ns.NetInputStream.read(Unknown Source)
                                oracle.jdbc.driver.T4CMAREngine.unmarshalUB1(T4CMAREngine.java:971)
                                oracle.jdbc.driver.T4CMAREngine.unmarshalSB1(T4CMAREngine.java:941)
                                oracle.jdbc.driver.T4C8Oall.receive(T4C8Oall.java:432)
                                oracle.jdbc.driver.T4CPreparedStatement.doOall8(T4CPreparedStatement.java:181)
                                oracle.jdbc.driver.T4CPreparedStatement.execute_for_describe(T4CPreparedStatement.java:420)
                                oracle.jdbc.driver.OracleStatement.execute_maybe_describe(OracleStatement.java:896)
                                oracle.jdbc.driver.T4CPreparedStatement.execute_maybe_describe(T4CPreparedStatement.java:452)
                                oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:986)
                                oracle.jdbc.driver.OraclePreparedStatement.executeInternal(OraclePreparedStatement.java:2888)
                                oracle.jdbc.driver.OraclePreparedStatement.executeQuery(OraclePreparedStatement.java:2929)
                                oracle.jdbc.OracleDatabaseMetaData.getTables(OracleDatabaseMetaData.java:2311)
                                com.mchange.v2.c3p0.impl.DefaultConnectionTester.activeCheckConnectionNoQuery(DefaultConnectionTester.java:185)
                                com.mchange.v2.c3p0.impl.DefaultConnectionTester.activeCheckConnection(DefaultConnectionTester.java:62)
                                com.mchange.v2.c3p0.AbstractConnectionTester.activeCheckConnection(AbstractConnectionTester.java:67)
                                com.mchange.v2.c3p0.impl.C3P0PooledConnectionPool$1PooledConnectionResourcePoolManager.testPooledConnection(C3P0PooledConnectionPool.java:368)
                                com.mchange.v2.c3p0.impl.C3P0PooledConnectionPool$1PooledConnectionResourcePoolManager.refurbishIdleResource(C3P0PooledConnectionPool.java:310)
                                com.mchange.v2.resourcepool.BasicResourcePool$AsyncTestIdleResourceTask.run(BasicResourcePool.java:1999)
                                com.mchange.v2.async.ThreadPoolAsynchronousRunner$PoolThread.run(ThreadPoolAsynchronousRunner.java:547)
                Thread[com.mchange.v2.async.ThreadPoolAsynchronousRunner$PoolThread-#1,5,main]
                                java.net.SocketInputStream.socketRead0(Native Method)
                                java.net.SocketInputStream.read(SocketInputStream.java:129)
                                oracle.net.ns.Packet.receive(Unknown Source)
                                oracle.net.ns.DataPacket.receive(Unknown Source)
                                oracle.net.ns.NetInputStream.getNextPacket(Unknown Source)
                                oracle.net.ns.NetInputStream.read(Unknown Source)
                                oracle.net.ns.NetInputStream.read(Unknown Source)
                                oracle.net.ns.NetInputStream.read(Unknown Source)
                                oracle.jdbc.driver.T4CMAREngine.unmarshalUB1(T4CMAREngine.java:971)
                                oracle.jdbc.driver.T4CMAREngine.unmarshalSB1(T4CMAREngine.java:941)
                                oracle.jdbc.driver.T4C8Oall.receive(T4C8Oall.java:432)
                                oracle.jdbc.driver.T4CPreparedStatement.doOall8(T4CPreparedStatement.java:181)
                                oracle.jdbc.driver.T4CPreparedStatement.execute_for_describe(T4CPreparedStatement.java:420)
                                oracle.jdbc.driver.OracleStatement.execute_maybe_describe(OracleStatement.java:896)
                                oracle.jdbc.driver.T4CPreparedStatement.execute_maybe_describe(T4CPreparedStatement.java:452)
                                oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:986)
                                oracle.jdbc.driver.OraclePreparedStatement.executeInternal(OraclePreparedStatement.java:2888)
                                oracle.jdbc.driver.OraclePreparedStatement.executeQuery(OraclePreparedStatement.java:2929)
                                oracle.jdbc.OracleDatabaseMetaData.getTables(OracleDatabaseMetaData.java:2311)
                                com.mchange.v2.c3p0.impl.DefaultConnectionTester.activeCheckConnectionNoQuery(DefaultConnectionTester.java:185)
                                com.mchange.v2.c3p0.impl.DefaultConnectionTester.activeCheckConnection(DefaultConnectionTester.java:62)
                                com.mchange.v2.c3p0.AbstractConnectionTester.activeCheckConnection(AbstractConnectionTester.java:67)
                                com.mchange.v2.c3p0.impl.C3P0PooledConnectionPool$1PooledConnectionResourcePoolManager.testPooledConnection(C3P0PooledConnectionPool.java:368)
                                com.mchange.v2.c3p0.impl.C3P0PooledConnectionPool$1PooledConnectionResourcePoolManager.refurbishIdleResource(C3P0PooledConnectionPool.java:310)
                                com.mchange.v2.resourcepool.BasicResourcePool$AsyncTestIdleResourceTask.run(BasicResourcePool.java:1999)
                                com.mchange.v2.async.ThreadPoolAsynchronousRunner$PoolThread.run(ThreadPoolAsynchronousRunner.java:547)
                Thread[com.mchange.v2.async.ThreadPoolAsynchronousRunner$PoolThread-#0,5,main]
                                java.net.SocketInputStream.socketRead0(Native Method)
                                java.net.SocketInputStream.read(SocketInputStream.java:129)
                                oracle.net.ns.Packet.receive(Unknown Source)
                                oracle.net.ns.DataPacket.receive(Unknown Source)
                                oracle.net.ns.NetInputStream.getNextPacket(Unknown Source)
                                oracle.net.ns.NetInputStream.read(Unknown Source)
                                oracle.net.ns.NetInputStream.read(Unknown Source)
                                oracle.net.ns.NetInputStream.read(Unknown Source)
                                oracle.jdbc.driver.T4CMAREngine.unmarshalUB1(T4CMAREngine.java:971)
                                oracle.jdbc.driver.T4CMAREngine.unmarshalSB1(T4CMAREngine.java:941)
                                oracle.jdbc.driver.T4C8Oall.receive(T4C8Oall.java:432)
                                oracle.jdbc.driver.T4CPreparedStatement.doOall8(T4CPreparedStatement.java:181)
                                oracle.jdbc.driver.T4CPreparedStatement.execute_for_describe(T4CPreparedStatement.java:420)
                                oracle.jdbc.driver.OracleStatement.execute_maybe_describe(OracleStatement.java:896)
                                oracle.jdbc.driver.T4CPreparedStatement.execute_maybe_describe(T4CPreparedStatement.java:452)
                                oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:986)
                                oracle.jdbc.driver.OraclePreparedStatement.executeInternal(OraclePreparedStatement.java:2888)
                                oracle.jdbc.driver.OraclePreparedStatement.executeQuery(OraclePreparedStatement.java:2929)
                                oracle.jdbc.OracleDatabaseMetaData.getTables(OracleDatabaseMetaData.java:2311)
                                com.mchange.v2.c3p0.impl.DefaultConnectionTester.activeCheckConnectionNoQuery(DefaultConnectionTester.java:185)
                                com.mchange.v2.c3p0.impl.DefaultConnectionTester.activeCheckConnection(DefaultConnectionTester.java:62)
                                com.mchange.v2.c3p0.AbstractConnectionTester.activeCheckConnection(AbstractConnectionTester.java:67)
                                com.mchange.v2.c3p0.impl.C3P0PooledConnectionPool$1PooledConnectionResourcePoolManager.testPooledConnection(C3P0PooledConnectionPool.java:368)
                                com.mchange.v2.c3p0.impl.C3P0PooledConnectionPool$1PooledConnectionResourcePoolManager.refurbishIdleResource(C3P0PooledConnectionPool.java:310)
                                com.mchange.v2.resourcepool.BasicResourcePool$AsyncTestIdleResourceTask.run(BasicResourcePool.java:1999)
                                com.mchange.v2.async.ThreadPoolAsynchronousRunner$PoolThread.run(ThreadPoolAsynchronousRunner.java:547)

This mis my hibernate config c3p0

<property name="connection.provider_class">
            org.hibernate.connection.C3P0ConnectionProvider
</property>        
<property name="hibernate.c3p0.min_size">5</property>
<property name="hibernate.c3p0.max_size">50</property>
<property name="hibernate.c3p0.timeout">5</property>
<property name="hibernate.c3p0.max_statements">0</property>
<property name="hibernate.c3p0.idle_test_period">60</property>

I can find bug in my code, but it make "APPARENT DEADLOCKS exception" What can i do?

like image 252
Viet Avatar asked Dec 14 '25 01:12

Viet


1 Answers

What is failing is the testing threads that check whether idle connections are still valid. Apparently the default query, getTables() which just gets a list of all tables in your schema, is timing out. Whether this is the database crumbling or not is hard to tell, but you're not helping things by having a timeout of 5 seconds, which is causing you to close and reopen all 5 connections every 5 seconds. Set it to something sensible like 1800. You may also try to set a different connection test, or just turn connection testing off entirely.

This configuration turns off idle testing and sets the timeout much higher:

<property name="hibernate.c3p0.min_size">5</property>
<property name="hibernate.c3p0.max_size">50</property>
<property name="hibernate.c3p0.timeout">1800</property>
<property name="hibernate.c3p0.max_statements">0</property>
like image 147
wds Avatar answered Dec 15 '25 14:12

wds