Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Android: Layouts not being added below each other

I'm trying to add multiple ConstraintLayouts below each other. But they appear to be on the same position. (See picture).

Question: How do I get the ConstraintLayouts to be below each other?

What's happpening right now:

Example 1:

enter image description here

Example 2:

enter image description here

How it should look like:

enter image description here

Activity.java

String response = (String) databaseManager.execute(phpLocation,  parameters).get();
        List<Review> listOfReviews = (List<Review>) EntityConverter.getInstance().jsonToObject(response,
                new TypeToken<Collection<Review>>(){}.getType());

        int totalscore = 0;
        int amountOfReviews = 0;

        RelativeLayout relativeLayoutReviews = (RelativeLayout) findViewById(R.id.relativeLayoutReviews);
        for(Review r : listOfReviews) {
            LayoutInflater vi = (LayoutInflater) getApplicationContext().getSystemService(Context.LAYOUT_INFLATER_SERVICE);
            View v = vi.inflate(R.layout.reviewtemplate, null);
            v.setId(amountOfReviews);

            TextView name = (TextView) v.findViewById(R.id.textViewReviewName);
            name.setText(r.getName());

            RatingBar ratingBar = (RatingBar) v.findViewById(R.id.ratingBarReviewScore);
            ratingBar.setRating(r.getScore());
            totalscore += r.getScore();

            TextView ratingText = (TextView) v.findViewById(R.id.textViewReviewText);
            ratingText.setText(r.getReviewtext());

            RelativeLayout.LayoutParams params = new RelativeLayout.LayoutParams(
                    RelativeLayout.LayoutParams.WRAP_CONTENT, RelativeLayout.LayoutParams.WRAP_CONTENT);

            if (amountOfReviews != 0) {
                // add the rule that places your button below your EditText object
                params.addRule(RelativeLayout.BELOW, v.getId() -1);
            }

            relativeLayoutReviews.addView(v, amountOfReviews);
            amountOfReviews++;
        }

reviewtemplate.xml (The thing which I'm trying to insert)

<?xml version="1.0" encoding="utf-8"?>
<android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:layout_width="match_parent"
    android:id="@+id/reviewTemplate"
    android:layout_height="match_parent">

    <TextView
        android:id="@+id/textViewReviewName"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_marginTop="16dp"
        android:text="Pietje"
        android:textSize="24sp"
        android:textColor="#000000"
        app:layout_constraintTop_toTopOf="parent"
        android:layout_marginLeft="8dp"
        app:layout_constraintLeft_toLeftOf="parent" />

    <RatingBar
        android:id="@+id/ratingBarReviewScore"
        android:layout_width="243dp"
        android:layout_height="58dp"
        android:numStars="5"
        android:rating="0"
        android:layout_marginTop="8dp"
        app:layout_constraintTop_toBottomOf="@+id/textViewReviewName"
        android:layout_marginLeft="8dp"
        app:layout_constraintLeft_toLeftOf="parent"
        android:layout_marginRight="8dp"
        app:layout_constraintRight_toRightOf="parent" />

    <TextView
        android:id="@+id/textViewReviewText"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_marginLeft="16dp"
        android:layout_marginRight="8dp"
        android:layout_marginTop="8dp"
        android:text="Text"
        android:textColor="#000000"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintTop_toBottomOf="@+id/ratingBarReviewScore" />
</android.support.constraint.ConstraintLayout>

RelativeLayout which will contain all the reviews.

<RelativeLayout
            android:id="@+id/relativeLayoutReviews"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:layout_marginEnd="20dp"
            android:layout_marginLeft="20dp"
            android:layout_marginRight="20dp"
            android:layout_marginStart="20dp"
            android:layout_marginTop="1dp"
            app:layout_constraintHorizontal_bias="0.0"
            app:layout_constraintLeft_toLeftOf="parent"
            app:layout_constraintRight_toRightOf="parent"
            app:layout_constraintTop_toTopOf="parent"> 
</RelativeLayout>
like image 955
Guido Avatar asked Dec 29 '25 13:12

Guido


1 Answers

That happens because the root (parent) layout is RelativeLayout instead of LinearLayout.

Child views added into a RelativeLayout do not position one after another because their parent lays out their positioning depending on their child attributes (hence why the positioning is relative).

Add them into a LinearLayout with vertical orientation instead.

like image 132
SuppressWarnings Avatar answered Jan 01 '26 03:01

SuppressWarnings



Donate For Us

If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!